Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back out background location access #6299

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Back out background location access #6299

merged 4 commits into from
Jun 15, 2022

Conversation

Johennes
Copy link
Contributor

The app was rejected in review, asking for details on how it uses location access in the background. It turns out that the corresponding labs flag is still disabled in release builds so we should avoid using the background location mode until that is changed.

Accordingly, this pull request reverts ab3acab and 56c6ef3.

CC @SBiOSoftWhare & @MaximeEvrard42

pixlwave
pixlwave reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but seems like some changes from the mention pills may have got mixed in here.

Riot/SupportingFiles/Info.plist Outdated Show resolved Hide resolved
Riot/SupportingFiles/Info.plist Outdated Show resolved Hide resolved
@ismailgulek ismailgulek self-requested a review June 15, 2022 08:14
@ismailgulek
Copy link
Contributor

ismailgulek commented Jun 15, 2022 •
edited
Loading

It seems the culprit is location background mode, i'll alter this PR to remove other changes (it seems there is no actually, they just moved to somewhere else in the file).

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CdYyDD

@ismailgulek ismailgulek merged commit c50f23f into develop Jun 15, 2022
@ismailgulek ismailgulek deleted the johannes/back-out-background-location-access branch June 15, 2022 09:18
Johennes added a commit that referenced this pull request Jun 21, 2022
@Johennes
Revert "Merge pull request #6299 from vector-im/johannes/back-out-bac…
b255bcd 
…kground-location-access"

This reverts commit c50f23f, reversing
changes made to ff06c68.
@Johennes Johennes mentioned this pull request Jun 21, 2022
Merged
8 tasks
stefanceriu pushed a commit that referenced this pull request Jun 28, 2022
@Johennes @stefanceriu
Revert "Merge pull request #6299 from vector-im/johannes/back-out-bac…
2595a51 
…kground-location-access"

This reverts commit c50f23f, reversing
changes made to ff06c68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave left review comments

@aringenbach aringenbach aringenbach left review comments

@ismailgulek ismailgulek ismailgulek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Johennes @ismailgulek @pixlwave @aringenbach