Invites are collapsed incorrectly #6300
Conversation
- use sender avatar instead of the target avatar for collapsed membership cell
gileluard
requested review from
a team,
ismailgulek and
pixlwave
and removed request for
a team
- fixed target ID for membership / join events
| } | ||
| else | ||
| { | ||
| targetId = event.sender; |
There was a problem hiding this comment.
I'm not sure I understand why this part is necessary. If the cell now always shows the sender avatar, then how come the targetId needs to be explicitly set to the sender here?
There was a problem hiding this comment.
You're right. I just found this bug while digging. I actually hesitated to add this fix and I can revert it if you want.
There was a problem hiding this comment.
I'm not very sure what the issue requested with and the avatars should show the invited user not the invitee. “2 users invited” would be correct. I believe he wanted to have invited user instead of the inviter. If that assumption is correct, i think we'll need this part? (and keep using targetId for avatars)
There was a problem hiding this comment.
@ismailgulek I agree. I've just checked with android people and they confirmed the behaviour is the same. I'll check with the design team in this case.
There was a problem hiding this comment.
@ismailgulek I've checked with @amshakal and we'll display the avatar of the invitee in the collapsed membership cell even if it's a bit inconsistent with the expanded membership.
There was a problem hiding this comment.
Great, thanks for checking.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/s4ZoZS |
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com>
- Update after review
* Invites are collapsed incorrectly - use invitee avatar instead of the target avatar for collapsed membership cell
resolves #4102
Now use sender avatar instead of the target avatar for collapsed membership cell