Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: VoiceOver: Add accessibility label and hint to the Record Voice Message button. #6323

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Accessibility: VoiceOver: Add accessibility label and hint to the Record Voice Message button. #6323

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbcdf59
Add accessibility label and hint to the Record Voice Message button.
robin24 Jun 20, 2022
4ebabe0
Add release note.
robin24 Jun 20, 2022
307f6ee
Remove unnecessary import for SwiftUI.
robin24 Jun 21, 2022
d297399
Update Riot/Modules/Room/VoiceMessages/VoiceMessageToolbarView.swift
robin24 Jun 21, 2022
003cfd9
Add German translation for the newly added a11y strings.
robin24 Jun 21, 2022
612795d
Revert "Add German translation for the newly added a11y strings."
robin24 Jun 21, 2022
abb9d67
Update Riot/Assets/en.lproj/Vector.strings
robin24 Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Riot/Assets/de.lproj/Vector.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1622,6 +1622,8 @@
// MARK: Threads
"room_thread_title" = "Thread";
"room_accessibility_thread_more" = "Mehr";
room_accessibility_record_voice_message = "Sprachnachricht aufnehmen";
room_accessibility_record_voice_message_hint = "Doppeltippen und halten um aufzunehmen.";
robin24 marked this conversation as resolved.
Show resolved Hide resolved
"room_accessibility_threads" = "Threads";
"room_event_copy_link_info" = "Link in die Zwischenablage kopiert.";
"room_event_action_reply_in_thread" = "Thread";
Expand Down
2 changes: 2 additions & 0 deletions Riot/Assets/en.lproj/Vector.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,8 @@ Tap the + to start adding people.";
"room_accessibility_threads" = "Threads";
"room_accessibility_hangup" = "Hang up";
"room_accessibility_thread_more" = "More";
room_accessibility_record_voice_message = "Record Voice Message";
room_accessibility_record_voice_message_hint = "Double-tap and hold to record.";
robin24 marked this conversation as resolved.
Show resolved Hide resolved
"room_place_voice_call" = "Voice call";
"room_open_dialpad" = "Dial pad";
"room_join_group_call" = "Join";
Expand Down
8 changes: 8 additions & 0 deletions Riot/Generated/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4451,6 +4451,14 @@ public class VectorL10n: NSObject {
public static var roomAccessibilityIntegrations: String {
return VectorL10n.tr("Vector", "room_accessibility_integrations")
}
/// Record Voice Message
public static var roomAccessibilityRecordVoiceMessage: String {
return VectorL10n.tr("Vector", "room_accessibility_record_voice_message")
}
/// Double-tap and hold to record.
public static var roomAccessibilityRecordVoiceMessageHint: String {
return VectorL10n.tr("Vector", "room_accessibility_record_voice_message_hint")
}
/// Search
public static var roomAccessibilitySearch: String {
return VectorL10n.tr("Vector", "room_accessibility_search")
Expand Down
2 changes: 2 additions & 0 deletions Riot/Modules/Room/VoiceMessages/VoiceMessageToolbarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ class VoiceMessageToolbarView: PassthroughView, NibLoadable, Themable, UIGesture
playbackView.waveformView.addGestureRecognizer(tapGesture)
tapGesture.delegate = self
self.tapGesture = tapGesture
primaryRecordButton.accessibilityLabel = VectorL10n.roomAccessibilityRecordVoiceMessage
primaryRecordButton.accessibilityHint = VectorL10n.roomAccessibilityRecordVoiceMessageHint

updateUIWithDetails(VoiceMessageToolbarViewDetails(), animated: false)
}
Expand Down
1 change: 1 addition & 0 deletions changelog.d/pr-6323.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Accessibility: VoiceOver: Added an accessibility label and hint to the Record Voice Message button.