Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reporting of live location shares (PSF-1066) #6326

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 21, 2022

This sets the display text of beacon_info events which enables the context menu on live location shares which in turn allows users to report the events. Other events in the menus will be implemented separately.

Timeline Location cell selected More menu
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 15 05 37 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 15 05 40 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 15 05 43

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@Johennes Johennes marked this pull request as draft June 21, 2022 13:16
Signed-off-by: Johannes Marbach <johannesm@element.io>
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

[self presentEventForwardingDialogForSelectedEvent:selectedEvent];
}]];
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the block above because there is another if below without !selectedEvent.location which effectively made this a no-op.

@Johennes Johennes marked this pull request as ready for review June 21, 2022 13:22
@Johennes Johennes requested review from a team, SBiOSoftWhare and Anderas and removed request for a team June 21, 2022 13:22
@codecov-commenter
Copy link

Codecov Report

Merging #6326 (04d3afe) into develop (a8514ed) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6326      +/-   ##
===========================================
- Coverage     6.24%    6.24%   -0.01%     
===========================================
  Files         1440     1440              
  Lines       155412   155439      +27     
  Branches     62532    62541       +9     
===========================================
  Hits          9705     9705              
- Misses      145302   145330      +28     
+ Partials       405      404       -1     
Impacted Files Coverage Δ
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 14.25% <0.00%> (-0.04%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Categories/UIView.swift 33.33% <0.00%> (-4.17%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 22.69% <0.00%> (-0.83%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
...s/Authentication/Common/AuthenticationModels.swift 45.94% <0.00%> (+18.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8514ed...04d3afe. Read the comment docs.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3kbqoT

@Johennes Johennes merged commit 046d7dc into develop Jun 28, 2022
@Johennes Johennes deleted the johannes/lls-reporting branch June 28, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants