Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Riot-Defaults property list #6373

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes #6273

This removes some unnecessary files. I did not migrate these defaults to RiotSettings, in order to keep the separation between MXKAppSettings and other app settings, at least for now.

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aringenbach aringenbach requested review from a team and phloux and removed request for a team July 4, 2022 14:06
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/diVrt1

@aringenbach aringenbach requested review from a team and ismailgulek and removed request for phloux and a team July 4, 2022 14:38
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Riot-Defaults out of property lists
2 participants