Fix inoperant room links with alias/identifiers

[aringenbach]

Fixes element-hq/element-web#6395

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/b1vFVS

[pixlwave]

I'm not against this change, but I've added a comment inline with a small query.

[codecov-commenter]

Codecov Report

Merging #6396 (8cf52d4) into develop (6340e8f) will increase coverage by 0.04%.
The diff coverage is 40.00%.

@@             Coverage Diff             @@
##           develop    vector-im/element-web#6396      +/-   ##
===========================================
+ Coverage     6.22%    6.26%   +0.04%     
===========================================
  Files         1451     1451              
  Lines       155597   155599       +2     
  Branches     62507    62509       +2     
===========================================
+ Hits          9689     9756      +67     
+ Misses      145504   145437      -67     
- Partials       404      406       +2     

Impacted Files	Coverage Δ
Riot/Utils/UniversalLink.m	65.54% <40.00%> (-1.13%)	⬇️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift	35.41% <0.00%> (-4.17%)	⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift	95.34% <0.00%> (-0.31%)	⬇️
...xKit/Controllers/MXKAuthenticationViewController.m	19.05% <0.00%> (ø)
...ing/SplashScreen/View/OnboardingSplashScreen.swift	58.66% <0.00%> (+4.00%)	⬆️
...on/NavigationController/RiotNavigationController.m	76.08% <0.00%> (+10.86%)	⬆️
Riot/Categories/String.swift	33.33% <0.00%> (+11.11%)	⬆️
...Modules/Common/ViewModel/StateStoreViewModel.swift	50.00% <0.00%> (+19.44%)	⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift	53.84% <0.00%> (+42.30%)	⬆️
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift	93.02% <0.00%> (+93.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6340e8f...8cf52d4. Read the comment docs.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[pixlwave]

Yeah that seems like a more sensible place to handle the error to me.

[aaronraimist]

I haven't tested this PR but it appears to linkify room IDs. FWIW Element Web intentionally does not linkify room IDs
element-hq/element-meta#1592
element-hq/element-meta#1592

[aringenbach]

Thanks for raising this @aaronraimist

As a matter of fact these we're "always" linkified but the navigation stopped working even on servers that know or host the room. I raised a separate issue here: #6404 to actually remove the linkify.