Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using an ephemeral web browser session on SSO #6464

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 21, 2022

The app has been using an ephemeral web browser session meaning users have to re-enter their username and password for accounts that are already signed in through Safari. This PR fixes that. It also renames the bundle name to Element for the SSO alert. Additionally

  • The second commit fixes build errors in the unit tests target
  • The last 2 commits fix an error on CI at the end of the unit tests lane.

Fixes #6462.

Old bundle name New bundle name
Simulator Screen Shot - iPhone SE (2nd generation) - 2022-07-21 at 14 30 04 Simulator Screen Shot - iPhone SE (2nd generation) - 2022-07-21 at 17 18 13

@github-actions
Copy link

github-actions bot commented Jul 21, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TCuzs1

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team July 25, 2022 08:36
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit 66a2d9f into develop Jul 27, 2022
@pixlwave pixlwave deleted the doug/6462-sso-cookies branch July 27, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO login isn't aware of any accounts that were signed-in through Safari.
2 participants