Fixes a glitch when dismissing a GIF in the media attachment viewer (#6475) #6476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch shows the animation would show in the background while the transition interaction occurred
Signed-off-by: Milton Moura <miltonmoura@gmail.com>
pixlwave
requested changes
Aug 1, 2022
Riot/Modules/MatrixKit/Animators/MXKAttachmentInteractionController.m
Outdated
Show resolved
Hide resolved
Riot/Modules/MatrixKit/Animators/MXKAttachmentInteractionController.m
Outdated
Show resolved
Hide resolved
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
…oller.m Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
…oller.m Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
|
thanks for the feedback @pixlwave - I will continue working in this area, as I've spotted some other issues with these interactions on the iPad. |
|
Thanks for the updates. Would you like me to hold this PR for those changes or would you prefer to open separate ones? |
pixlwave
approved these changes
Aug 5, 2022
|
No need to hold the PR, I will submit a new one, as they issues are not specific to GIF viewing. |
|
Super, PR merged. Thanks for you contribution 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Fixes #6475 - Added logic to the interaction controller, when the interaction starts and cancels, so we can hide / show the WKWebView when the attachment is a GIF image type.
Video clip of issue
gif-webview-glitch.mp4
Video clip of solved issue
gif-webview-glitch-fixed.mov