Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location sharing: Improve live location sharing expanded map state when no more live location shares (PSG-628) #6490

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

SBiOSoftWhare
Copy link
Contributor

#6488

Light Dark
IMG_0050 IMG_0049

@SBiOSoftWhare SBiOSoftWhare requested review from a team, aringenbach and gaelledel and removed request for a team July 28, 2022 07:37
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/r5fqJJ

@codecov-commenter
Copy link

Codecov Report

Merging #6490 (c069899) into develop (66a2d9f) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6490      +/-   ##
===========================================
+ Coverage     6.16%    6.22%   +0.05%     
===========================================
  Files         1453     1453              
  Lines       155867   155897      +30     
  Branches     62625    62639      +14     
===========================================
+ Hits          9615     9708      +93     
+ Misses      145854   145785      -69     
- Partials       398      404       +6     
Impacted Files Coverage Δ
...haringViewer/LiveLocationSharingViewerModels.swift 0.00% <0.00%> (ø)
...ingViewer/LiveLocationSharingViewerViewModel.swift 0.00% <0.00%> (ø)
...SharingViewer/View/LiveLocationSharingViewer.swift 0.00% <0.00%> (ø)
...ules/Room/LocationSharing/LocationAnnotation.swift 0.00% <ø> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 7.53% <0.00%> (+0.41%) ⬆️
Riot/Modules/Application/LegacyAppDelegate.m 13.28% <0.00%> (+0.64%) ⬆️
...anagers/PushNotification/PushNotificationService.m 11.48% <0.00%> (+1.04%) ⬆️
...ActivityIndicator/ActivityIndicatorPresenter.swift 51.72% <0.00%> (+2.29%) ⬆️
Riot/Modules/Application/AppDelegate.swift 55.38% <0.00%> (+4.61%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a2d9f...c069899. Read the comment docs.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -48,6 +48,15 @@ struct LiveLocationSharingViewerViewState: BindableState {
var shareButtonEnabled: Bool {
!showLoadingIndicator
}

/// True to indicate that everybody stopped to share live location sharing in the room
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// True to indicate that everybody stopped to share live location sharing in the room
/// True to indicate that everybody stopped live location sharing in the room

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants