-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location sharing: Improve live location sharing expanded map state when no more live location shares (PSG-628) #6490
Conversation
Kudos, SonarCloud Quality Gate passed! |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/r5fqJJ |
Codecov Report
@@ Coverage Diff @@
## develop #6490 +/- ##
===========================================
+ Coverage 6.16% 6.22% +0.05%
===========================================
Files 1453 1453
Lines 155867 155897 +30
Branches 62625 62639 +14
===========================================
+ Hits 9615 9708 +93
+ Misses 145854 145785 -69
- Partials 398 404 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -48,6 +48,15 @@ struct LiveLocationSharingViewerViewState: BindableState { | |||
var shareButtonEnabled: Bool { | |||
!showLoadingIndicator | |||
} | |||
|
|||
/// True to indicate that everybody stopped to share live location sharing in the room |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// True to indicate that everybody stopped to share live location sharing in the room | |
/// True to indicate that everybody stopped live location sharing in the room |
#6488