Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the attachment navigation bar into a container. #6525

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 3, 2022

The navigation bar wasn't using the safe area correctly, so it is now inside of a container that ignores the safe area and the top of the bar is aligned to the top of the safe area.

Realistically this view should use a Navigation Controller but this interferes animations so I've themed the container to match the nav bar. One down side of this is that it won't gain the system material when we enable the new app layout 😕

Fixes #6486.

Light Mode Dark Mode iPhone SE
Simulator Screen Shot - iPhone 13 mini - 2022-08-03 at 14 27 22 Simulator Screen Shot - iPhone 13 mini - 2022-08-03 at 14 27 29 Simulator Screen Shot - iPhone SE (3rd generation) - 2022-08-03 at 14 44 15

@pixlwave pixlwave requested review from a team and SBiOSoftWhare and removed request for a team August 3, 2022 13:48
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/neNzuF

@codecov-commenter
Copy link

Codecov Report

Merging #6525 (59b0790) into develop (c9e916b) will increase coverage by 0.04%.
The diff coverage is 21.42%.

@@             Coverage Diff             @@
##           develop    #6525      +/-   ##
===========================================
+ Coverage     6.20%    6.24%   +0.04%     
===========================================
  Files         1462     1462              
  Lines       157168   157174       +6     
  Branches     63166    63167       +1     
===========================================
+ Hits          9745     9815      +70     
+ Misses      147014   146949      -65     
- Partials       409      410       +1     
Impacted Files Coverage Δ
...ules/Room/Attachements/AttachmentsViewController.m 0.00% <0.00%> (ø)
...s/Room/Attachements/MXKAttachmentsViewController.m 0.00% <0.00%> (ø)
...iewControllerWithBannerWrapperViewController.swift 46.91% <100.00%> (+2.04%) ⬆️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 35.41% <0.00%> (-4.17%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 19.01% <0.00%> (ø)
...SharingViewer/View/LiveLocationSharingViewer.swift
...gViewer/MockStaticLocationViewingScreenState.swift
...cationSharing/View/LocationSharingMarkerView.swift
...haring/View/UserAnnotationCalloutContentView.swift
...Coordinator/StaticLocationViewingCoordinator.swift
... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pixlwave pixlwave merged commit 9ab59b5 into develop Aug 3, 2022
@pixlwave pixlwave deleted the doug/6486-media-nav-bar branch August 3, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View image: Top layout exception.
3 participants