Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the contacts permission string. #6551

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 10, 2022

Fixes #6549.

Simulator Screen Shot - iPhone 13 mini - 2022-08-10 at 11 58 52

@pixlwave pixlwave requested review from a team and ismailgulek and removed request for a team August 10, 2022 10:58
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aUYdTD

@codecov-commenter
Copy link

Codecov Report

Merging #6551 (f45d003) into develop (36b4a35) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6551      +/-   ##
===========================================
+ Coverage     6.16%    6.28%   +0.11%     
===========================================
  Files         1473     1458      -15     
  Lines       157969   153913    -4056     
  Branches     63491    61864    -1627     
===========================================
- Hits          9746     9671      -75     
+ Misses      147819   143836    -3983     
- Partials       404      406       +2     
Impacted Files Coverage Δ
...es/Room/VoiceMessages/VoiceMessageController.swift 0.00% <ø> (ø)
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 0.00% <0.00%> (-93.03%) ⬇️
Riot/Categories/String.swift 22.22% <0.00%> (-11.12%) ⬇️
...it/Controllers/MXKActivityHandlingViewController.m 64.58% <0.00%> (-6.25%) ⬇️
Riot/Modules/MatrixKit/Utils/MXKTools.h 57.14% <0.00%> (-5.36%) ⬇️
Riot/Modules/TabBar/MasterTabBarController.m 34.93% <0.00%> (-1.52%) ⬇️
Riot/Modules/TabBar/TabBarCoordinator.swift 23.23% <0.00%> (-0.86%) ⬇️
...ules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m 16.05% <0.00%> (-0.71%) ⬇️
Riot/Managers/Settings/RiotSettings.swift 87.71% <0.00%> (-0.22%) ⬇️
Riot/Modules/MatrixKit/Utils/MXKTools.m 20.20% <0.00%> (-0.13%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pixlwave pixlwave changed the base branch from develop to hotfix/1.8.25 August 10, 2022 13:23
@pixlwave pixlwave merged commit 982fb52 into hotfix/1.8.25 Aug 10, 2022
@pixlwave pixlwave deleted the doug/6549-contacts-permissions branch August 10, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contacts permission string.
3 participants