Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitchy room list header when scrolling #6660

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard commented Sep 1, 2022

resolves #6513, resolves #6537

ezgif-3-651b50cf69
ezgif-3-add3297fcc

@gileluard gileluard requested review from a team and stefanceriu and removed request for a team September 1, 2022 15:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #6660 (46c0e5b) into develop (a87eb94) will increase coverage by 0.38%.
The diff coverage is 0.55%.

@@             Coverage Diff             @@
##           develop    #6660      +/-   ##
===========================================
+ Coverage     5.80%    6.19%   +0.38%     
===========================================
  Files         1474     1474              
  Lines       155154   156125     +971     
  Branches     62228    62560     +332     
===========================================
+ Hits          9013     9667     +654     
- Misses      145752   146056     +304     
- Partials       389      402      +13     
Impacted Files Coverage Δ
...les/Common/Recents/DataSources/RecentsDataSource.m 6.75% <0.00%> (-0.02%) ⬇️
...iot/Modules/Common/Recents/RecentsViewController.m 8.64% <0.00%> (-0.06%) ⬇️
...Modules/Common/Recents/Views/RecentTableViewCell.m 0.00% <ø> (ø)
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 0.00% <0.00%> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 0.00% <0.00%> (ø)
...ules/Home/AllChats/RoomInvitesViewController.swift 0.00% <0.00%> (ø)
Riot/Modules/Room/MXKRoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/SplitView/SplitViewCoordinator.swift 33.33% <0.00%> (-1.31%) ⬇️
...ew/SplitViewUserIndicatorPresentationContext.swift 31.25% <ø> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Bwgezy

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed all the code as I assume it's mostly copied from the existing coordinators but otherwise it looks good to me 👍

Riot/Modules/Room/RoomViewController.m Outdated Show resolved Hide resolved
Riot/Modules/SplitView/SplitViewCoordinator.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gileluard gileluard merged commit d5e54af into develop Sep 5, 2022
@gileluard gileluard deleted the gil/6513-Glitchy_room_list_header_when_scrolling branch September 5, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issues with new App Layout Glitchy room list header when scrolling
3 participants