Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when previewing a room. #6713

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 13, 2022

There was a crash from a couple of new Swift classes not handling the completion as optional.

Fixes #6712

internal static let roomActionDirectChat = ImageAsset(name: "room_action_direct_chat")
internal static let roomActionFavourite = ImageAsset(name: "room_action_favourite")
internal static let roomActionLeave = ImageAsset(name: "room_action_leave")
internal static let roomActionNotification = ImageAsset(name: "room_action_notification")
internal static let roomActionNotificationMuted = ImageAsset(name: "room_action_notification_muted")
internal static let roomActionPriorityHigh = ImageAsset(name: "room_action_priority_high")
internal static let roomActionPriorityLow = ImageAsset(name: "room_action_priority_low")
internal static let allChatEditLayout = ImageAsset(name: "all_chat_edit_layout")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but seemed worth checking in at the same time.

@pixlwave pixlwave requested review from a team and gileluard and removed request for a team September 13, 2022 12:19
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #6713 (0506d31) into develop (a12ef01) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6713      +/-   ##
===========================================
- Coverage     9.95%    9.92%   -0.04%     
===========================================
  Files         1482     1482              
  Lines       150314   150311       -3     
  Branches     60679    60676       -3     
===========================================
- Hits         14957    14911      -46     
- Misses      134806   134849      +43     
  Partials       551      551              
Impacted Files Coverage Δ
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 22.06% <0.00%> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 28.73% <0.00%> (ø)
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 0.00% <0.00%> (-93.03%) ⬇️
Riot/Categories/String.swift 55.55% <0.00%> (-11.12%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zsC5c6

@pixlwave pixlwave merged commit 7b67ed6 into develop Sep 13, 2022
@pixlwave pixlwave deleted the doug/6712-fix-room-preview-crash branch September 13, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to preview a room crashes the app.
2 participants