Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only disable the composer if the room is yet to be created. #6733

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

pixlwave
Copy link
Member

Fixes #6708 as the composer was being disabled and then immediately re-enabled. Didn't figure out why this was only visible on some devices, but the fix was to not disable the composer in an existing room.

Before After
Before After

@pixlwave pixlwave requested review from a team, aringenbach and yostyle and removed request for a team September 16, 2022 18:59
@pixlwave
Copy link
Member Author

@yostyle Added you for the review to double check you're happy with the change :)

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 9.96% // Head: 9.94% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (61100ba) compared to base (60c8be0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6733      +/-   ##
===========================================
- Coverage     9.96%    9.94%   -0.02%     
===========================================
  Files         1484     1484              
  Lines       150509   150506       -3     
  Branches     60753    60750       -3     
===========================================
- Hits         14995    14975      -20     
- Misses      134960   134978      +18     
+ Partials       554      553       -1     
Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 54.66% <0.00%> (-4.00%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/skaVHa

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit a5804a3 into develop Sep 19, 2022
@stefanceriu stefanceriu deleted the doug/6708-fix-composer-jumping branch September 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboards jumps at every sent message
3 participants