Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render of links with both characters requiring percent encoding and markdown-like syntax #6759

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Fix render of links with both characters requiring percent encoding and markdown-like syntax #6759

merged 1 commit into from
Sep 23, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes #6748

@aringenbach aringenbach requested review from a team, phloux and stefanceriu and removed request for a team and phloux September 23, 2022 13:08
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/smFHDt

@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited
Loading

Codecov Report

Base: 10.04% // Head: 10.02% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (04ef849) compared to base (5635bf7).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6759      +/-   ##
===========================================
- Coverage    10.04%   10.02%   -0.02%     
===========================================
  Files         1490     1490              
  Lines       150805   150806       +1     
  Branches     60858    60857       -1     
===========================================
- Hits         15143    15121      -22     
- Misses      135108   135131      +23     
  Partials       554      554
Impacted Files Coverage Δ
.../Utils/EventFormatter/MarkdownToHTMLRenderer.swift 85.95% <66.66%> (+0.11%) ⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
.../UserSessionDetails/UserSessionDetailsModels.swift 0.00% <0.00%> (-36.37%) ⬇️
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 88.37% <0.00%> (-4.66%) ⬇️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 54.66% <0.00%> (-4.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

stefanceriu
stefanceriu approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@aringenbach aringenbach merged commit b5184fa into develop Sep 23, 2022
@aringenbach aringenbach deleted the aringenbach/6748_fix_percent_encoding_and_markdown branch September 23, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong URL sent in message
2 participants
@aringenbach @stefanceriu