Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device manager: Inactive sessions screen #6791

Merged
merged 13 commits into from
Oct 5, 2022
Merged

Device manager: Inactive sessions screen #6791

merged 13 commits into from
Oct 5, 2022

Conversation

paleksandrs
Copy link
Contributor

@paleksandrs paleksandrs commented Oct 4, 2022 •
edited
Loading

Closes #6786

Light Dark
inactive_light inactive_dark

AC:

  • ‘View all’ buttons from security recommendations section links to screen with correct filter applied to sessions
  • Sessions are ordered by latest activity timestamp in descending order
  • Navigating back returns to main session management screen

@paleksandrs
User other sessions screen template
0b85beb
@paleksandrs
Refactored creation of UserSessionListItemViewData, added inactive se…
899539f 
…ssion icon
@paleksandrs
Cleanup
70f6bad
@paleksandrs
Added translation strings, cleanup
ca3a401
@paleksandrs
Merge branch 'develop' into aleksandrs/6786_inactive_sessions_screen
3deee90 
# Conflicts:
#	Riot/Assets/en.lproj/Vector.strings
#	Riot/Generated/Strings.swift
#	RiotSwiftUI/Modules/UserSessions/Coordinator/UserSessionsFlowCoordinator.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionOverview/Test/Unit/UserSessionOverviewViewModelTests.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/Coordinator/UserSessionsOverviewCoordinator.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/Service/Mock/MockUserSessionsOverviewService.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/UserSessionsOverviewModels.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/View/UserSessionListItemViewData.swift
@paleksandrs
Renamed session to sessionInfo
34aa035
@paleksandrs
Changelog
1da7dac
@paleksandrs
Fixed formating
aae5ccd
@paleksandrs
Formating fixes
5ec1bb3
@paleksandrs
Added tests
347724f
@paleksandrs
Cleanup for UserSessionOverviewViewModelTestsc, UserOtherSessionsView…
9dad625 
…ModelTests
@paleksandrs paleksandrs marked this pull request as ready for review October 5, 2022 06:18
@paleksandrs paleksandrs requested review from a team and gileluard and removed request for a team October 5, 2022 06:19
gileluard
gileluard approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paleksandrs
Merge branch 'develop' into aleksandrs/6786_inactive_sessions_screen
7e09a6e 
# Conflicts:
#	RiotSwiftUI/Modules/UserSessions/UserSessionDetails/UserSessionDetailsViewModel.swift
@paleksandrs
Merge fixes
87cc0dd
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 10.62% // Head: 10.68% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (87cc0dd) compared to base (bf9bb82).
Patch coverage: 70.34% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6791      +/-   ##
===========================================
+ Coverage    10.62%   10.68%   +0.06%     
===========================================
  Files         1504     1512       +8     
  Lines       151651   151944     +293     
  Branches     61180    61271      +91     
===========================================
+ Hits         16110    16239     +129     
- Misses      134972   135133     +161     
- Partials       569      572       +3
Impacted Files Coverage Δ
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)
...ons/Coordinator/UserOtherSessionsCoordinator.swift 0.00% <0.00%> (ø)
...ls/Coordinator/UserSessionDetailsCoordinator.swift 0.00% <0.00%> (ø)
.../Coordinator/UserSessionsOverviewCoordinator.swift 0.00% <0.00%> (ø)
...rSessionsOverview/UserSessionsOverviewModels.swift 100.00% <ø> (ø)
...onsOverview/View/UserSessionListItemViewData.swift 100.00% <ø> (ø)
...ssionsOverview/UserSessionsOverviewViewModel.swift 65.71% <50.00%> (-6.17%) ⬇️
...UserOtherSessions/UserOtherSessionsViewModel.swift 54.16% <54.16%> (ø)
...herSessions/View/UserOtherSessionsHeaderView.swift 68.29% <68.29%> (ø)
...ons/UserOtherSessions/View/UserOtherSessions.swift 79.41% <79.41%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DKj45G

@paleksandrs paleksandrs merged commit 6eef04a into develop Oct 5, 2022
@paleksandrs paleksandrs deleted the aleksandrs/6786_inactive_sessions_screen branch October 5, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gileluard gileluard gileluard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device manager: Inactive sessions screen
2 participants
@paleksandrs @gileluard