Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display push toggle for sessions with m.local_notification_settings.<… #6798

Conversation

gileluard
Copy link
Contributor

resolves #6797

@gileluard gileluard requested review from a team and ismailgulek and removed request for a team October 4, 2022 14:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 51.34% // Head: 10.57% // Decreases project coverage by -40.76% ⚠️

Coverage data is based on head (c97917b) compared to base (f37f08b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6798       +/-   ##
============================================
- Coverage    51.34%   10.57%   -40.77%     
============================================
  Files          370     1504     +1134     
  Lines        14177   151645   +137468     
  Branches      5776    61180    +55404     
============================================
+ Hits          7279    16037     +8758     
- Misses        6722   135039   +128317     
- Partials       176      569      +393     
Impacted Files Coverage Δ
...Service/MatrixSDK/UserSessionOverviewService.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 84.00% <0.00%> (-5.37%) ⬇️
...dinator/LiveLocationSharingViewerCoordinator.swift 0.00% <0.00%> (ø)
...Backup/Setup/Passphrase/PasswordStrengthView.swift 0.00% <0.00%> (ø)
Riot/Categories/MXSessionState.swift 0.00% <0.00%> (ø)
...irectoryServerList/MXKDirectoryServersDataSource.m 0.00% <0.00%> (ø)
...elineCells/SizableCell/SizingViewHeightStore.swift 0.00% <0.00%> (ø)
.../Models/RoomList/MXKInterleavedRecentsDataSource.m 2.64% <0.00%> (ø)
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 13.34% <0.00%> (ø)
...r/Service/MatrixSDK/MatrixItemChooserService.swift 0.00% <0.00%> (ø)
... and 1155 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Sv1B2n

@gileluard gileluard merged commit 2b9ca86 into develop Oct 4, 2022
@gileluard gileluard deleted the gil/6797-Display_push_toggle_for_sessions_with_m.local_notification_settings.device-id branch October 4, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display push toggle for sessions with m.local_notification_settings.<device-id> events in account_data
2 participants