Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include app name in default session display name #6828

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Include app name in default session display name #6828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96f6f6
Include app name in default session display name
Johennes Oct 7, 2022
390b452
Add changelog
Johennes Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Riot/Assets/en.lproj/Vector.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,6 +2392,9 @@ To enable access, tap Settings> Location and select Always";

// MARK: User sessions management

// Parameter is the application display name (e.g. "Element")
"user_sessions_default_session_display_name" = "%@ iOS";

"user_sessions_overview_title" = "Sessions";

"user_sessions_overview_security_recommendations_section_title" = "Security recommendations";
Expand Down
2 changes: 1 addition & 1 deletion Riot/Categories/UIDevice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import UIKit
}

var initialDisplayName: String {
isPhone ? VectorL10n.loginMobileDevice : VectorL10n.loginTabletDevice
VectorL10n.userSessionsDefaultSessionDisplayName(AppInfo.current.displayName)
}

}
4 changes: 4 additions & 0 deletions Riot/Generated/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8743,6 +8743,10 @@ public class VectorL10n: NSObject {
public static var userSessionViewDetails: String {
return VectorL10n.tr("Vector", "user_session_view_details")
}
/// %@ iOS
public static func userSessionsDefaultSessionDisplayName(_ p1: String) -> String {
return VectorL10n.tr("Vector", "user_sessions_default_session_display_name", p1)
}
/// Current session
public static var userSessionsOverviewCurrentSessionSectionTitle: String {
return VectorL10n.tr("Vector", "user_sessions_overview_current_session_section_title")
Expand Down
1 change: 1 addition & 0 deletions changelog.d/6828.change
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Include app name in default session display name