Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update the nav bar from the top SwiftUI hosting controller. #6834

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 8, 2022

Fixes #6833. The glitch was caused by my fix for #6738 not taking into account the embedded SwiftUI UserSuggestions module in RoomViewController, so it was modifying the navigation bar when it shouldn't have.

I've tested this change on iOS 15/16 with the auth flow and the navigation bar shows/hides as intended.

@pixlwave pixlwave requested review from a team and Anderas and removed request for a team October 8, 2022 13:03
@pixlwave pixlwave changed the title Only update the nav bar from the top SwiftUI view. Only update the nav bar from the top SwiftUI hosting controller. Oct 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QDYkJm

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/1.9.8@7f48870). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             hotfix/1.9.8    #6834   +/-   ##
===============================================
  Coverage                ?   53.99%           
===============================================
  Files                   ?      402           
  Lines                   ?    15772           
  Branches                ?     6342           
===============================================
  Hits                    ?     8516           
  Misses                  ?     7068           
  Partials                ?      188           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave force-pushed the doug/6833-fix-all-chats-header-glitch branch from a50c166 to 2c8df87 Compare October 10, 2022 08:22
@pixlwave pixlwave changed the base branch from develop to hotfix/1.9.8 October 10, 2022 08:22
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave merged commit 628c517 into hotfix/1.9.8 Oct 10, 2022
@pixlwave pixlwave deleted the doug/6833-fix-all-chats-header-glitch branch October 10, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The All Chats view header sometimes shows the last room's navigation bar contents.
2 participants