Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ffmpeg pod. #6841

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Remove the ffmpeg pod. #6841

merged 1 commit into from
Oct 10, 2022

Conversation

pixlwave
Copy link
Member

Looks like it was missed out during #6419.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave requested review from a team and gileluard and removed request for a team October 10, 2022 11:26
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vLEfjv

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 53.99% // Head: 53.99% // No change to project coverage 👍

Coverage data is based on head (8a6f004) compared to base (61d5185).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6841   +/-   ##
========================================
  Coverage    53.99%   53.99%           
========================================
  Files          402      402           
  Lines        15772    15772           
  Branches      6343     6344    +1     
========================================
  Hits          8516     8516           
  Misses        7068     7068           
  Partials       188      188           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gileluard
Copy link
Contributor

Nothing related but the CI fails due to this error:
type 'MockAuthenticationRestClient' does not conform to protocol 'AuthenticationRestClient'

@pixlwave
Copy link
Member Author

Oh yeah, hmmm I'll go have a look into what might have cause that 👍

@pixlwave pixlwave merged commit 6031077 into develop Oct 10, 2022
@pixlwave pixlwave deleted the doug/remove-ffmpeg branch October 10, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants