Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Manager: Navigating to session overview goes to session details #6878

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

paleksandrs
Copy link
Contributor

closes #6877

Selecting a session from other sessions screen should go to session overview.

@paleksandrs paleksandrs requested review from a team and aringenbach and removed request for a team October 14, 2022 06:25
@paleksandrs paleksandrs marked this pull request as ready for review October 14, 2022 06:26
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Jch5NL

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 11.63% // Head: 11.78% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (8d6804e) compared to base (380ad94).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6878      +/-   ##
===========================================
+ Coverage    11.63%   11.78%   +0.15%     
===========================================
  Files         1559     1573      +14     
  Lines       155250   156062     +812     
  Branches     62667    63075     +408     
===========================================
+ Hits         18060    18399     +339     
- Misses      136578   137044     +466     
- Partials       612      619       +7     
Impacted Files Coverage Δ
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)
...ons/Coordinator/UserOtherSessionsCoordinator.swift 0.00% <0.00%> (ø)
...ns/UserOtherSessions/UserOtherSessionsModels.swift 100.00% <ø> (ø)
...dules/Common/SwiftUI/VectorHostingController.swift 71.59% <0.00%> (-4.66%) ⬇️
...ogin/Common/Service/MatrixSDK/QRLoginService.swift 8.53% <0.00%> (-3.11%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/MXKRoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/DataSources/RoomDataSource.swift 0.00% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paleksandrs paleksandrs merged commit b4af93c into develop Oct 14, 2022
@paleksandrs paleksandrs deleted the aleksandrs/6877_navigation_fix branch October 14, 2022 08:01
@aringenbach aringenbach removed their request for review November 23, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Manager: Navigating to session overview goes to session details
2 participants