Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Notifications on this device" not refreshed in user settings screen #6889

Merged

Conversation

gileluard
Copy link
Contributor

resolves #6888

@gileluard gileluard requested review from a team and ismailgulek and removed request for a team October 14, 2022 13:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 11.79% // Head: 11.78% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (9301960) compared to base (928b5f3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6889      +/-   ##
===========================================
- Coverage    11.79%   11.78%   -0.01%     
===========================================
  Files         1573     1573              
  Lines       156078   156074       -4     
  Branches     63083    63080       -3     
===========================================
- Hits         18404    18397       -7     
- Misses      137056   137058       +2     
- Partials       618      619       +1     
Impacted Files Coverage Δ
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Util/View+Riot.swift 71.42% <0.00%> (-28.58%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 90.71% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/958AoH

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gileluard gileluard merged commit ff0faf5 into develop Oct 17, 2022
@gileluard gileluard deleted the gil/6888-Notifications_on_this_device_not_refreshed branch October 17, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Notifications on this device" not refreshed in user settings screen
2 participants