Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All chats shows no rooms in the list #6890

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

gileluard
Copy link
Contributor

Resolves #6869

@gileluard gileluard requested review from a team and phloux and removed request for a team October 14, 2022 15:24
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9P1ZAP

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 6.16% // Head: 6.17% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5bd756d) compared to base (622f351).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6890   +/-   ##
========================================
  Coverage     6.16%    6.17%           
========================================
  Files         1571     1571           
  Lines       156047   156050    +3     
  Branches     63019    63022    +3     
========================================
+ Hits          9626     9635    +9     
+ Misses      145993   145986    -7     
- Partials       428      429    +1     
Impacted Files Coverage Δ
...Modules/Home/AllChats/AllChatsViewController.swift 28.77% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.61% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gileluard gileluard merged commit c394135 into develop Oct 15, 2022
@gileluard gileluard deleted the gil/6869-All_chats_shows_no_rooms_in_the_list branch October 15, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All chats shows no rooms in the list
2 participants