Rich Text Composer Placeholder Text #6938
Conversation
| if (!savedInputToolbarPlaceholder) | ||
| if (toolbarView.placeholder) | ||
| { | ||
| savedInputToolbarPlaceholder = toolbarView.placeholder.length ? toolbarView.placeholder : @""; | ||
| savedInputToolbarPlaceholder = toolbarView.placeholder; | ||
| } | ||
|
|
||
| toolbarView.placeholder = nil; |
There was a problem hiding this comment.
This code was a bit unreliable so I improved it, since sometimes it removed the placeholder text when the height of it did change, without restoring it properly.
In reality I think most of the code of this function can safely be removed.
I actually tested removing this code alongside lines 5014 to 5020, and actually the placeholder works fine since both in the new composer and the old composer it uses the redraw contentMode.
And it looked even better on both composers, since the placeholder did even stop blinking
Can I actually just remove it?
@langleyd
Codecov ReportBase: 6.15% // Head: 11.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6938 +/- ##
===========================================
+ Coverage 6.15% 11.75% +5.60%
===========================================
Files 1590 1592 +2
Lines 156596 156638 +42
Branches 63190 63255 +65
===========================================
+ Hits 9633 18418 +8785
+ Misses 146534 137599 -8935
- Partials 429 621 +192
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
Implemented a responsive placeholder text in the RichTextComposer using the same logic of the normal composer
RPReplay_Final1666187799.MP4