Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AvatarView crash #6947

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix AvatarView crash #6947

merged 1 commit into from
Oct 20, 2022

Conversation

alfogrillo
Copy link
Contributor

This PR fixes a potential crash introduced by this PR: #6927
It looks like sometimes the avatar view doesn't have the inner image view ready.

@alfogrillo alfogrillo requested review from a team, stefanceriu and pixlwave and removed request for a team and stefanceriu October 20, 2022 15:03
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 11.75% // Head: 11.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6a97778) compared to base (5a7fcaf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6947   +/-   ##
========================================
  Coverage    11.75%   11.75%           
========================================
  Files         1594     1594           
  Lines       156706   156709    +3     
  Branches     63322    63324    +2     
========================================
+ Hits         18424    18427    +3     
  Misses      137660   137660           
  Partials       622      622           
Flag Coverage Δ
unittests 6.14% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Common/Avatar/AvatarView.swift 35.29% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 4db5962 into develop Oct 20, 2022
@alfogrillo alfogrillo deleted the alfogrillo/fix_avatar_crash branch October 20, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants