Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Manager: Session list item is not tappable everywhere #7037

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Device Manager: Session list item is not tappable everywhere #7037

merged 2 commits into from
Nov 7, 2022

Conversation

paleksandrs
Copy link
Contributor

Closes #7035

@paleksandrs paleksandrs marked this pull request as ready for review November 4, 2022 13:57
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Base: 11.77% // Head: 11.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ef5aa4d) compared to base (43f2abe).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #7037   +/-   ##
========================================
  Coverage    11.77%   11.78%           
========================================
  Files         1611     1611           
  Lines       158181   158184    +3     
  Branches     64242    64245    +3     
========================================
+ Hits         18631    18635    +4     
  Misses      138921   138921           
+ Partials       629      628    -1
Flag Coverage Δ
uitests 54.63% <66.66%> (+<0.01%) ⬆️
unittests 6.08% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...serSessionsOverview/View/UserSessionListItem.swift 65.06% <66.66%> (+1.20%) ⬆️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alfogrillo
alfogrillo approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGTM! 🎉

@paleksandrs paleksandrs merged commit 3c2b4a3 into develop Nov 7, 2022
@paleksandrs paleksandrs deleted the aleksandrs/7035_session_list_item_tap_fix branch November 7, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfogrillo alfogrillo alfogrillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Manager: Session list item is not tappable everywhere
2 participants
@paleksandrs @alfogrillo