Force a layout on the room bubble cell messageTextView to get a corre… #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
force-pushed
the
stefan/timelineLayoutFixes
branch
from
6cb3574
to
6d04899
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
requested review from
a team and
aringenbach
and removed request for
a team
Codecov ReportBase: 11.32% // Head: 11.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7064 +/- ##
===========================================
+ Coverage 11.32% 11.80% +0.48%
===========================================
Files 1613 1617 +4
Lines 158555 158586 +31
Branches 64352 64453 +101
===========================================
+ Hits 17961 18727 +766
+ Misses 139966 139221 -745
- Partials 628 638 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces a layout on the bubbleCell messageTextView used for computing the heights of the bubble components. It will ensure the reactions and other attachment views are layed out correctly.