Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dm code coverage (PSG-925) #7065

Merged
merged 10 commits into from
Nov 11, 2022

Conversation

alfogrillo
Copy link
Contributor

This PR adds missing UI/Unit test to improve the code coverage of the new Device Manager.

@alfogrillo alfogrillo requested review from a team and ismailgulek and removed request for a team November 10, 2022 11:24
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 11.72% // Head: 11.77% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (f575c97) compared to base (2184f1f).
Patch coverage: 31.89% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7065      +/-   ##
===========================================
+ Coverage    11.72%   11.77%   +0.05%     
===========================================
  Files         1613     1620       +7     
  Lines       158529   158723     +194     
  Branches     64369    64563     +194     
===========================================
+ Hits         18589    18696     +107     
- Misses      139305   139390      +85     
- Partials       635      637       +2     
Flag Coverage Δ
uitests 54.90% <51.86%> (+0.42%) ⬆️
unittests 5.98% <4.95%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
Riot/Categories/MXKRoomBubbleTableViewCell+Riot.m 0.00% <0.00%> (ø)
Riot/Managers/Settings/RiotSettings.swift 88.33% <ø> (-0.10%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
Riot/Modules/TabBar/MasterTabBarController.m 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Extensions/View.swift 0.00% <0.00%> (ø)
...n/InfoSheet/Coordinator/InfoSheetCoordinator.swift 0.00% <0.00%> (ø)
.../Modules/Common/InfoSheet/InfoSheetViewModel.swift 0.00% <0.00%> (ø)
...es/Common/InfoSheet/MockInfoSheetScreenState.swift 0.00% <0.00%> (ø)
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise lgtm!

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alfogrillo alfogrillo merged commit 01326dc into develop Nov 11, 2022
@alfogrillo alfogrillo deleted the alfogrillo/increase_dm_code_coverage branch November 11, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants