Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text Editor: Fixing Voice Dictation not working #7073

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 14, 2022

Only supports plain text dictation for now.

RPReplay_Final1668439918.MP4

@Velin92 Velin92 linked an issue Nov 14, 2022 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Velin92 Velin92 added the Trigger-PR-Build Label to trigger builds for PRs label Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 11.67% // Head: 11.76% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (a2f07a7) compared to base (6ed6bc0).
Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7073      +/-   ##
===========================================
+ Coverage    11.67%   11.76%   +0.09%     
===========================================
  Files         1620     1620              
  Lines       158820   158743      -77     
  Branches     64603    64553      -50     
===========================================
+ Hits         18537    18672     +135     
+ Misses      139641   139434     -207     
+ Partials       642      637       -5     
Flag Coverage Δ
uitests 54.95% <100.00%> (+0.35%) ⬆️
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Application/LegacyAppDelegate.m 14.45% <0.00%> (-0.01%) ⬇️
...imelinePoll/Coordinator/TimelinePollProvider.swift 0.00% <0.00%> (ø)
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 87.50% <100.00%> (+11.54%) ⬆️
...UserSessions/Common/View/UserSessionCardView.swift 50.75% <0.00%> (+1.09%) ⬆️
...rOtherSessions/View/UserOtherSessionsToolbar.swift 89.61% <0.00%> (+1.29%) ⬆️
...Sessions/Common/View/UserSessionCardViewData.swift 88.15% <0.00%> (+1.31%) ⬆️
...ingViewer/LiveLocationSharingViewerViewModel.swift 54.38% <0.00%> (+1.75%) ⬆️
...serSessionsOverview/View/UserSessionListItem.swift 64.28% <0.00%> (+2.92%) ⬆️
...erSessionDetails/UserSessionDetailsViewModel.swift 88.00% <0.00%> (+3.00%) ⬆️
...herSessions/View/UserOtherSessionsHeaderView.swift 53.70% <0.00%> (+3.70%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9QKhVq

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 merged commit 602cf76 into develop Nov 15, 2022
@Velin92 Velin92 deleted the mauroromito/6945_voice_dictation branch November 15, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labs: Rich text-editor does support voice-dictation
2 participants