Rich Text Editor: Adding/Editing Links feature

[Velin92]

RPReplay_Final1670867683.MP4

[codecov]

Codecov Report

Base: 11.74% // Head: 11.83% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (501eb8d) compared to base (1efa7c1).
Patch coverage: 52.77% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7158      +/-   ##
===========================================
+ Coverage    11.74%   11.83%   +0.08%     
===========================================
  Files         1621     1627       +6     
  Lines       159428   159793     +365     
  Branches     64922    65150     +228     
===========================================
+ Hits         18732    18911     +179     
- Misses      140058   140244     +186     
  Partials       638      638              

Flag	Coverage Δ
uitests	54.94% <74.34%> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Riot/Modules/Room/RoomViewController.swift	0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift	0.00% <0.00%> (ø)
...oordinator/ComposerLinkActionBridgePresenter.swift	0.00% <0.00%> (ø)
...on/Coordinator/ComposerLinkActionCoordinator.swift	0.00% <0.00%> (ø)
...tSwiftUI/Modules/Room/Composer/View/Composer.swift	80.39% <0.00%> (-5.03%)	⬇️
...Action/ViewModel/ComposerLinkActionViewModel.swift	43.47% <43.47%> (ø)
...es/Room/Composer/ViewModel/ComposerViewModel.swift	31.37% <50.00%> (+1.58%)	⬆️
...I/Modules/Room/Composer/Model/ComposerModels.swift	75.00% <57.14%> (-4.04%)	⬇️
.../Composer/LinkAction/View/ComposerLinkAction.swift	87.50% <87.50%> (ø)
...List/MockComposerCreateActionListScreenState.swift	100.00% <100.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hgkzGR

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[aringenbach]

LGTM

Found a RTE library bug:

• Insert a link
• Backspace to the beginning of the field
• Write something
• => Link is preserved and usable because of NSAttributedString (until sending or doing an action that triggers a replaceAll)

Note: this can be fixed now or later depending how easy it is. (I'm pretty sure backspacing should almost always trigger an actual replaceAll but that could have many side effects 🙃 )

[Velin92]

LGTM

Found a RTE library bug:

• Insert a link
• Backspace to the beginning of the field
• Write something
• => Link is preserved and usable because of NSAttributedString (until sending or doing an action that triggers a replaceAll)

Note: this can be fixed now or later depending how easy it is. (I'm pretty sure backspacing should almost always trigger an actual replaceAll but that could have many side effects 🙃 )

This requires a fix on the library, so maybe I'll open a separate ticket and separate bug ticket for that.
But thanks a lot for bringing it up! I'll start tracking it!