Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the thread list using server-side sorting and pagination #7185

Conversation

gileluard
Copy link
Contributor

resolves #6059

@gileluard gileluard requested review from a team and phloux and removed request for a team December 19, 2022 13:58
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 11.82% // Head: 11.84% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8a9f1d2) compared to base (7428273).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7185      +/-   ##
===========================================
+ Coverage    11.82%   11.84%   +0.01%     
===========================================
  Files         1628     1628              
  Lines       159992   159984       -8     
  Branches     65224    65231       +7     
===========================================
+ Hits         18924    18948      +24     
+ Misses      140430   140396      -34     
- Partials       638      640       +2     
Flag Coverage Δ
uitests 54.79% <ø> (+0.05%) ⬆️
unittests 5.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Threads/ThreadList/ThreadListViewController.swift 0.00% <0.00%> (ø)
...dules/Threads/ThreadList/ThreadListViewModel.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
...ingViewer/LiveLocationSharingViewerViewModel.swift 54.38% <0.00%> (+1.75%) ⬆️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 80.29% <0.00%> (+2.93%) ⬆️
...I/Modules/Room/Composer/Model/ComposerModels.swift 75.58% <0.00%> (+19.14%) ⬆️
...Modules/Room/Composer/View/FormattingToolbar.swift 73.68% <0.00%> (+30.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gileluard gileluard merged commit c4d66d6 into develop Dec 28, 2022
@gileluard gileluard deleted the gil/6059-Load_thread_list_using_server-side_sorting_and_pagination branch December 28, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load the thread list using server-side sorting and pagination
2 participants