Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for reactions on VB (#7179) #7243

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jan 6, 2023

This PR contains:

  • allow to perform actions on a voice broadcast event (MXKRoomDataSource)
  • take into account the height of the reactions area in a VoiceBroadcastPlaybackPlainCell (RoomBubbleCellData)

@nimau nimau added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Reactions A-Voice-Broadcast labels Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 11.83% // Head: 11.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (61ad177) compared to base (daea28b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7243      +/-   ##
===========================================
- Coverage    11.83%   11.83%   -0.01%     
===========================================
  Files         1629     1629              
  Lines       160154   160217      +63     
  Branches     65386    65415      +29     
===========================================
+ Hits         18962    18968       +6     
- Misses      140555   140612      +57     
  Partials       637      637              
Flag Coverage Δ
uitests 54.86% <ø> (+0.01%) ⬆️
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 12.98% <0.00%> (-0.04%) ⬇️
Riot/Modules/Room/CellData/RoomBubbleCellData.m 0.00% <0.00%> (ø)
...ast/Playback/VoiceBroadcastPlaybackPlainCell.swift 0.00% <0.00%> (ø)
...ast/Recorder/VoiceBroadcastRecorderPlainCell.swift 0.00% <0.00%> (ø)
...r/Coordinator/VoiceBroadcastRecorderProvider.swift 0.00% <0.00%> (ø)
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
...ingViewer/LiveLocationSharingViewerViewModel.swift 54.38% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau requested a review from weeman1337 January 9, 2023 13:47
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nimau
Copy link
Contributor Author

nimau commented Jan 9, 2023

@weeman1337 I've added a check to ensure that we only manage start events. Can you tell me if this is the correct way to check ?

@weeman1337
Copy link

@weeman1337 I've added a check to ensure that we only manage start events. Can you tell me if this is the correct way to check ?

Logic looks good. You should get this reviewed by some iOS developer 🙃

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@nimau nimau merged commit ec02f51 into develop Jan 9, 2023
@nimau nimau deleted the nimau/7179_VB_reactions branch January 9, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions A-Voice-Broadcast T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants