-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for reactions on VB (#7179) #7243
Conversation
Codecov ReportBase: 11.83% // Head: 11.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7243 +/- ##
===========================================
- Coverage 11.83% 11.83% -0.01%
===========================================
Files 1629 1629
Lines 160154 160217 +63
Branches 65386 65415 +29
===========================================
+ Hits 18962 18968 +6
- Misses 140555 140612 +57
Partials 637 637
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Kudos, SonarCloud Quality Gate passed! |
@weeman1337 I've added a check to ensure that we only manage start events. Can you tell me if this is the correct way to check ? |
Logic looks good. You should get this reviewed by some iOS developer 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
This PR contains: