Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll history: load more polls (PSG-1093) #7303

Merged
merged 23 commits into from
Jan 26, 2023

Conversation

alfogrillo
Copy link
Contributor

Description

This PR improves the poll history by adding the following features:

  • Add the possibility to manually fetch more polls backwards
  • Handle live poll updates
  • Show errors when the pagination fails

Result

poc

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 11.99% // Head: 12.02% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (fc8ee97) compared to base (971a9f0).
Patch coverage: 49.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7303      +/-   ##
===========================================
+ Coverage    11.99%   12.02%   +0.02%     
===========================================
  Files         1632     1628       -4     
  Lines       161153   161168      +15     
  Branches     65958    66031      +73     
===========================================
+ Hits         19330    19379      +49     
+ Misses      141178   141146      -32     
+ Partials       645      643       -2     
Flag Coverage Δ
uitests 55.70% <86.84%> (+0.39%) ⬆️
unittests 5.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...llHistory/Coordinator/PollHistoryCoordinator.swift 0.00% <0.00%> (ø)
...History/Service/MatrixSDK/PollHistoryService.swift 0.00% <0.00%> (ø)
...UI/Modules/Room/PollHistory/View/PollHistory.swift 90.17% <76.47%> (+1.49%) ⬆️
...odules/Room/PollHistory/PollHistoryViewModel.swift 81.48% <83.33%> (+1.48%) ⬆️
.../Room/PollHistory/MockPollHistoryScreenState.swift 94.44% <89.65%> (-5.56%) ⬇️
...lHistory/Service/Mock/MockPollHistoryService.swift 97.87% <91.66%> (-2.13%) ⬇️
...I/Modules/Room/PollHistory/PollHistoryModels.swift 100.00% <100.00%> (ø)
...linePoll/View/TimelinePollAnswerOptionButton.swift 53.96% <100.00%> (+0.74%) ⬆️
...m/AllChatsOnboarding/View/AllChatsOnboarding.swift
.../AllChatsOnboarding/AllChatsOnboardingModels.swift
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit 87d8aec into develop Jan 26, 2023
@alfogrillo alfogrillo deleted the alfogrillo/poll_history_load_more branch January 26, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants