Sync polls rules error handling (PSG-1126)

[alfogrillo]

Description

This PR adds an error state in the notification settings to be seen whenever the normal messages rules don't match the one of polls.

Dependency

#7320

Result

[codecov]

Codecov Report

Base: 12.00% // Head: 11.99% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4f5dfe3) compared to base (2ead5ed).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7324      +/-   ##
===========================================
- Coverage    12.00%   11.99%   -0.01%     
===========================================
  Files         1630     1630              
  Lines       161448   161481      +33     
  Branches     66234    66263      +29     
===========================================
- Hits         19377    19374       -3     
- Misses      141427   141463      +36     
  Partials       644      644              

Flag	Coverage Δ
uitests	55.26% <0.00%> (-0.11%)	⬇️
unittests	5.92% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ings/Notifications/View/NotificationSettings.swift	0.00% <0.00%> (ø)
...ions/ViewModel/NotificationSettingsViewModel.swift	0.00% <0.00%> (ø)
...ions/ViewModel/NotificationSettingsViewState.swift	0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift	95.34% <0.00%> (-0.31%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pixlwave]

Ok, code looks good to me, but it seems like a really weird change to me.

If another client added more granular support for changing push rules (which iirc are per account rather than per device), and a user decided to let users disable notifications for polls (seems a valid thing to not care about your day being interrupted by), then we're going to show errors for that user when they chose it configure it that way.

Did we consider running a one-time update of the rules to our new defaults, and then letting the user set them as they would like without considering it to be an error?

[alfogrillo]

Ok, code looks good to me, but it seems like a really weird change to me.

If another client added more granular support for changing push rules (which iirc are per account rather than per device), and a user decided to let users disable notifications for polls (seems a valid thing to not care about your day being interrupted by), then we're going to show errors for that user when they chose it configure it that way.

Did we consider running a one-time update of the rules to our new defaults, and then letting the user set them as they would like without considering it to be an error?

I think the rational was to make the Element's UX easier for the user.
There is a related discussion here if you want to contribute! 🙏🏻
I'm not considering this a blocker for now anyway.

[pixlwave]

No, not a blocker for sure, just felt it doesn't look at the wider picture of Matrix as a whole :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information