-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to find own location in map views #7337
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportBase: 12.09% // Head: 12.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7337 +/- ##
===========================================
- Coverage 12.09% 12.08% -0.01%
===========================================
Files 1637 1637
Lines 161830 161846 +16
Branches 66429 66484 +55
===========================================
- Hits 19566 19564 -2
- Misses 141618 141636 +18
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm not sure I understand the need of adding a button here as zoom in and finding user location should be automatic when opening the map. Also this is the space dedicated to the Sharing option why are you replacing it? |
Thanks for getting back @gaelledel.
This is for the case when the user is not sharing their own location but instead viewing somebody else's location share.
The screenshot is from the live location map view. That one currently doesn't have the share button. You are right though that for static location shares, the map view would have to show both, the share button and the "find my location" button. |
@Johennes You can find a design reference for this here https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=3103%3A64256&t=tF5nsVNzfBrN9ZYh-4 |
This exposes the default "find my location" button in the map view dialog for static and live locations. When the user is currently live-sharing their own location, the button is hidden.
Todo
I couldn't find a suitable existing icon for this so I reused one of the map marker icons for demonstration purposes. We'll probably need to make a new one.
It also currently only centers the map on the user location when clicking for the first time.
Screenshots
Pull Request Checklist