Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some voice message issues (#7325, #7217) #7357

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Feb 9, 2023

Fix #7325: prevent setting the audio session to inactive during recording
Fix #7217: ensure that an audio player has its content loaded when it reaches the end to allow seek and replay.

Fix #7325: prevent setting the audio session to inactive during recording
Fix #7217: ensure that an audio player has its content loaded when it reaches the end to allow seek and replay.
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 12.08% // Head: 12.08% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8a1f0b9) compared to base (0b6aa1f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7357   +/-   ##
========================================
  Coverage    12.08%   12.08%           
========================================
  Files         1637     1637           
  Lines       161867   161905   +38     
  Branches     66447    66467   +20     
========================================
+ Hits         19566    19574    +8     
- Misses      141655   141684   +29     
- Partials       646      647    +1     
Flag Coverage Δ
uitests 55.39% <ø> (+0.02%) ⬆️
unittests 5.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Room/VoiceMessages/VoiceMessageAudioPlayer.swift 0.00% <0.00%> (ø)
...Room/VoiceMessages/VoiceMessageAudioRecorder.swift 0.00% <0.00%> (ø)
...es/Room/VoiceMessages/VoiceMessageController.swift 0.00% <0.00%> (ø)
...iceMessages/VoiceMessageMediaServiceProvider.swift 0.00% <0.00%> (ø)
...VoiceMessages/VoiceMessagePlaybackController.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...odules/Room/PollHistory/View/SegmentedPicker.swift 58.92% <0.00%> (+22.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants