Manage bad m.file attachment format #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#7406 By using value type checker methods. With this fix, attachments with a wrong size format are still displayed in the timeline. Only the size is omitted
manuroe
requested review from
a team,
stefanceriu and
Anderas
and removed request for
a team and
stefanceriu
Anderas
approved these changes
Mar 16, 2023
| if (fileSize) | ||
| { | ||
| body = [NSString stringWithFormat:@"%@ (%@)", body, [MXTools fileSizeToString: fileSize.longValue]]; | ||
| } | ||
| else | ||
| { | ||
| MXLogDebug(@"[MXKEventFormatter] Warning: Unsupported m.file format: %@", event.description); |
There was a problem hiding this comment.
Could use MXLogErrorDetails here instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7406
By using value type checker methods.
With this fix, attachments with a wrong
sizeformat are still displayed in the timeline. Only the size is omitted like on the last item on this screenshot: