Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slash commands suggestion list #7514

Merged
merged 15 commits into from
Apr 24, 2023
Merged

Slash commands suggestion list #7514

merged 15 commits into from
Apr 24, 2023

Conversation

aringenbach
Copy link
Contributor

Fixes #7493

@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 24.20% and no project coverage change.

Comparison is base (ffc1a43) 12.36% compared to head (05cb486) 12.36%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop    #7514    +/-   ##
=========================================
  Coverage    12.36%   12.36%            
=========================================
  Files         1644     1646     +2     
  Lines       162983   163318   +335     
  Branches     66878    67056   +178     
=========================================
+ Hits         20145    20190    +45     
- Misses      142179   142466   +287     
- Partials       659      662     +3
Flag Coverage Δ
uitests 55.00% <48.66%> (-0.27%) ⬇️
unittests 6.21% <3.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/DataSources/RoomDataSource.swift 0.00% <ø> (ø)
Riot/Modules/Room/MXKRoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
.../Views/InputToolbar/RoomInputToolbarTextView.swift 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
.../Coordinator/CompletionSuggestionCoordinator.swift 0.00% <0.00%> (ø)
...inator/CompletionSuggestionCoordinatorBridge.swift 0.00% <0.00%> (ø)
.../Service/CompletionSuggestionServiceProtocol.swift 100.00% <ø> (ø)
...I/Modules/Room/Composer/Model/ComposerModels.swift 85.18% <0.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aringenbach aringenbach requested review from a team and nimau and removed request for a team April 21, 2023 15:14
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nimau
nimau approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@aringenbach aringenbach merged commit 5cfac70 into develop Apr 24, 2023
@aringenbach aringenbach deleted the aringenbach/7493_slash_commands_suggestion_list branch April 24, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimau nimau nimau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labs: Rich-Text-Editor: Integrate slash commands support
2 participants
@aringenbach @nimau