Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the position of the marker highlighting an event. #7533

Merged
merged 3 commits into from
May 3, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented May 3, 2023

This PR fixes #7526

Current behaviour:
7526_old

New behaviour:
7526_new

@nimau nimau requested review from a team and stefanceriu and removed request for a team May 3, 2023 09:58
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you that this works as intended ¯_(ツ)_/¯

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (379e8e2) 12.22% compared to head (5a85793) 12.22%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7533   +/-   ##
========================================
  Coverage    12.22%   12.22%           
========================================
  Files         1646     1646           
  Lines       163363   163368    +5     
  Branches     67063    67066    +3     
========================================
+ Hits         19968    19971    +3     
- Misses      142752   142754    +2     
  Partials       643      643           
Flag Coverage Δ
uitests 55.06% <ø> (ø)
unittests 6.06% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/MXKRoomBubbleTableViewCell+Riot.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau merged commit 9da37b4 into develop May 3, 2023
@nimau nimau deleted the nimau/7526_marker_overlap_bubble branch May 3, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sender display name is cut off when we jump to a message via a permalink
2 participants