Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevents UserAvatarView from disappearing due to incorrect width. #7587

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jun 7, 2023

This PR fixes an issue where the user's avatar can disappear from the top left menu of AllChatsViewController because the width of the AvatarView has become 0.

@nimau nimau force-pushed the nimau/PSB268_avatar_disappears branch from a279909 to 9997a16 Compare June 7, 2023 15:00
@nimau nimau marked this pull request as ready for review June 7, 2023 15:00
@nimau nimau requested review from a team and flescio and removed request for a team June 7, 2023 15:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@flescio flescio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15 ⚠️

Comparison is base (b10b75c) 12.36% compared to head (9997a16) 12.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7587      +/-   ##
===========================================
- Coverage    12.36%   12.21%   -0.15%     
===========================================
  Files         1648     1648              
  Lines       163663   163667       +4     
  Branches     67211    67194      -17     
===========================================
- Hits         20238    19999     -239     
- Misses      142760   143023     +263     
+ Partials       665      645      -20     
Flag Coverage Δ
unittests 6.06% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 26.29% <100.00%> (+0.51%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau merged commit 3cdedd6 into develop Jun 7, 2023
@nimau nimau deleted the nimau/PSB268_avatar_disappears branch June 7, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants