Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deactivate account if the auth property is present on the WK. #7654

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 24, 2023

fixes #7648

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy when you know how 🙃

I think there's a missing SDK PR to go alongside this, but certainly looks good in the app.

@Velin92
Copy link
Member Author

Velin92 commented Aug 24, 2023

Easy when you know how 🙃

I think there's a missing SDK PR to go alongside this, but certainly looks good in the app.

matrix-org/matrix-ios-sdk#1812
Already merged!

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83e7229) 12.22% compared to head (76c2687) 12.22%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7654   +/-   ##
========================================
  Coverage    12.22%   12.22%           
========================================
  Files         1648     1648           
  Lines       163619   163619           
  Branches     67155    67155           
========================================
  Hits         19997    19997           
  Misses      142976   142976           
  Partials       646      646           
Flag Coverage Δ
unittests 6.07% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 296d4a9 into develop Aug 24, 2023
13 checks passed
@Velin92 Velin92 deleted the mauroromito/7648_hide_deactivation_for_oidc branch August 24, 2023 16:36
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app should hide account deactivation in OIDC-aware mode
3 participants