Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jitsi conference terminated function ends the call correctly #7710

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Jitsi conference terminated function ends the call correctly #7710

merged 2 commits into from
Nov 14, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 14, 2023

fixes #7709

pixlwave
pixlwave approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Riot/Modules/Integrations/Widgets/Jitsi/JitsiViewController.m Outdated Show resolved Hide resolved
@Velin92 @pixlwave
Update Riot/Modules/Integrations/Widgets/Jitsi/JitsiViewController.m
925e3cf 
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
@Velin92 Velin92 merged commit 5a0a0f9 into develop Nov 14, 2023
4 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_for_confernce_terminated branch November 14, 2023 17:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jitsi call does not end when a moderator ends the call for everyone
2 participants
@Velin92 @pixlwave