Fix a bug where QR codes aren't detected if the camera is too close. #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/qr-code-accuracy
branch
from
bddacff
to
7506fee
Compare
pixlwave
commented
Mar 4, 2024
| @@ -59,7 +59,7 @@ end | |||
| def import_SwiftUI_pods | |||
| pod 'Introspect', '~> 0.1' | |||
| pod 'DSBottomSheet', '~> 0.3' | |||
| pod 'ZXingObjC', '~> 3.6.5' | |||
| pod 'ZXingObjC', '~> 3.6.9' | |||
There was a problem hiding this comment.
I tried this first, and seems worth leaving it pinned to the latest version.
pixlwave
requested review from
a team and
Velin92
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7762 +/- ##
========================================
Coverage 12.38% 12.39%
========================================
Files 1650 1650
Lines 163910 163864 -46
Branches 66401 66392 -9
========================================
+ Hits 20308 20314 +6
+ Misses 142934 142882 -52
Partials 668 668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Velin92
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were reports about not being able to scan QR codes to verify a device, but it turns out that it does work, just not if you fill the entire frame with the code. Moving back a bit so the code is smaller does work.
My conclusion was that the
applyRectOfInterestmethod isn't really necessary as we don't do that when logging in with a QR code. The removal of that method has no effect on the UI, it simply constrained the area of the capture that ZXing was looking in.