Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase decryption failure grace period #7764

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

BillCarsonFr
Copy link
Member

Pull Request Checklist

Increase decryption failure grace period as per element-hq/element-meta#2303

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@BillCarsonFr BillCarsonFr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 6, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ideally we would have a changelog for this.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 12.23%. Comparing base (2ec3ae1) to head (a1d59b3).

Files Patch % Lines
Riot/Modules/Analytics/DecryptionFailureTracker.m 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7764      +/-   ##
===========================================
- Coverage    12.39%   12.23%   -0.16%     
===========================================
  Files         1650     1650              
  Lines       163861   163861              
  Branches     66390    66371      -19     
===========================================
- Hits         20305    20044     -261     
- Misses      142888   143172     +284     
+ Partials       668      645      -23     
Flag Coverage Δ
uitests 55.05% <ø> (+<0.01%) ⬆️
unittests 6.05% <50.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 0b8fb85 into develop Apr 2, 2024
9 of 10 checks passed
@Velin92 Velin92 deleted the valere/increase_decryption_grace_period branch April 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants