Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various general project updates #7766

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Various general project updates #7766

merged 6 commits into from
Mar 19, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Mar 19, 2024

  • Add .xcprivacy info files to the main app, the notification service extension and the broadcast upload one
  • switch the default Xcode version used to 15.2
  • switch the github actions to the macos-14 runner

@stefanceriu stefanceriu changed the title Privacy info Privacy info + base SDK bump Mar 19, 2024
@stefanceriu stefanceriu changed the title Privacy info + base SDK bump Various general project updates Mar 19, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming it all builds well. We should make an internal TF build once this is merged to spot and changes from Xcode 15. Also should probably have a changelog to indicate to forks that we've swapped to 15.2.

@pixlwave pixlwave added the Trigger-PR-Build Label to trigger builds for PRs label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 12.41%. Comparing base (2ec3ae1) to head (608f760).

Files Patch % Lines
...rOtherSessions/View/UserOtherSessionsToolbar.swift 81.81% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7766      +/-   ##
===========================================
+ Coverage    12.39%   12.41%   +0.02%     
===========================================
  Files         1650     1650              
  Lines       163861   163903      +42     
  Branches     66390    67322     +932     
===========================================
+ Hits         20305    20356      +51     
- Misses      142888   142892       +4     
+ Partials       668      655      -13     
Flag Coverage Δ
uitests 55.66% <81.81%> (+0.61%) ⬆️
unittests 6.20% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/os2BRB

@stefanceriu stefanceriu removed the Trigger-PR-Build Label to trigger builds for PRs label Mar 19, 2024
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit c89637d into develop Mar 19, 2024
8 checks passed
@stefanceriu stefanceriu deleted the stefan/privacyInfo branch March 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants