-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert DecryptionFailureTracker to swift + tests #7769
Conversation
@@ -213,6 +213,38 @@ import AnalyticsEvents | |||
} | |||
} | |||
|
|||
@objc | |||
protocol E2EAnalytics { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just extracted that protocol to make testing of decryption failure tracker easier
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7769 +/- ##
===========================================
+ Coverage 12.19% 12.25% +0.06%
===========================================
Files 1650 1651 +1
Lines 164100 164133 +33
Branches 67487 67490 +3
===========================================
+ Hits 20012 20116 +104
+ Misses 143420 143346 -74
- Partials 668 671 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Preliminary work for #7767
Converts DecryptionFailureTracker from objective-c to swift to ease future changes.
Also added some tests. I didn't find any existing mock framework, so I modified a bit the code to be easily testable
Pull Request Checklist