Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving a second verification request from the same device doesn't visibly cancel the first #10118

Closed
turt2live opened this issue Jun 19, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3123
Closed

Receiving a second verification request from the same device doesn't visibly cancel the first #10118

turt2live opened this issue Jun 19, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3123
Assignees
@turt2live
Labels
A-E2EE A-E2EE-SAS-Verification P1 T-Defect

Comments

@turt2live
Copy link
Member

  1. Have 2 clients
  2. With Client 1, start verifying Client 2 - DO NOT ACCEPT.
  3. Refresh Client 1
  4. With Client 1, start verifying Client 2 again
  5. Verify Client 1 from Client 2
  6. Sudden incoming request from Client 1 still on Client 2

Step 6 should be a cancelled dialog or just not shown.
@turt2live turt2live self-assigned this Jun 19, 2019
@turt2live
Copy link
Member Author

This is potentially the cause of #9103

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 19, 2019
@turt2live
Consider cancelled verifications when mounting IncomingSasDialog
ff3c52a 
The cancellation can be because of a background problem, or because the user received another verification request from the same user. The cancel function does get called, however due to the speed of our dialog handling the state ends up being lost forever. Instead of trying to de-layer dialogs, this just fastforwards the whole dialog to "cancelled" on mount if required.

Fixes element-hq/element-web#10118
@turt2live turt2live mentioned this issue Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-E2EE A-E2EE-SAS-Verification P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider cancelled verifications when mounting IncomingSasDialog matrix-org/matrix-react-sdk
1 participant
@turt2live