Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should make it clear in the UI that device names are publicly readable #10216

Closed
ara4n opened this issue Jun 30, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3326
Closed

We should make it clear in the UI that device names are publicly readable #10216

ara4n opened this issue Jun 30, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3326
Assignees
@dbkr
Labels
Privacy T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jun 30, 2019

This just needs a little bit of microcopy.

Same goes for Riot/iOS & Riot/Android
@turt2live
Copy link
Member

related: https://github.com/vector-im/riot-web/issues/2295 https://github.com/vector-im/riot-web/issues/10153

This was referenced Aug 16, 2019
Closed
Closed
@dbkr dbkr self-assigned this Aug 19, 2019
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 19, 2019
@dbkr
Clarify that device names are publicly visible
f7083ac 
And also a bunch of other UI fixes in the devices table:
 * It's the devices table, don't need 'device' in all the headers
 * Not really necessary to label checkboxes with 'select'
 * Stop table from moving down when the delete button appears

Fixes element-hq/element-web#10216
@dbkr dbkr mentioned this issue Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
Privacy T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify that device names are publicly visible matrix-org/matrix-react-sdk
4 participants
@jryans @dbkr @turt2live @ara4n