Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on a signup validation link in the wrong browser gives you no way to progress the signup in the browser you started with #1027

Closed
ara4n opened this issue Feb 25, 2016 · 3 comments
Closed

Clicking on a signup validation link in the wrong browser gives you no way to progress the signup in the browser you started with #1027

ara4n opened this issue Feb 25, 2016 · 3 comments
Assignees
@dbkr
Labels
P1 T-Defect
Milestone
v0 - Friendly Beta

Comments

@ara4n
Copy link
Member

ara4n commented Feb 25, 2016

No description provided.

@ara4n ara4n added this to the v0 - Friendly Beta milestone Feb 25, 2016
@ara4n
Copy link
Member Author

ara4n commented Feb 25, 2016

  1. Sign up in one browser
  2. Receive validation email
  3. Click link in validation email on phone; open mobile browser; pass CAPTCHA
  4. No way to progress the signup on the first browser, short of refreshing and starting over as a login.

@ara4n ara4n mentioned this issue Feb 26, 2016
Closed
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 16, 2016
@dbkr
Poll for email validation once the validation email has been sent, an…
c9ad370 
…d continue with the registration process if/when it succeeds.

Fixes element-hq/element-web#1027
Requires matrix-org/synapse#650 and matrix-org/synapse#649
@dbkr dbkr mentioned this issue Mar 16, 2016
Merged
@ara4n
Copy link
Member Author

ara4n commented Mar 16, 2016

@dbkr I hit a new problem with this (beyond polling to see if the email has been validated) earlier today: if you are signing up using a non-matrix.org HS, the session that loads in the 'wrong' browser will default to the wrong HS/IS and all hell breaks loose. I think :/

@dbkr
Copy link
Member

dbkr commented Mar 17, 2016

Ah yep, looks like this was broken in matrix-org/matrix-react-sdk@0bb58dd

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 17, 2016
@dbkr
Make getCurrent[H|I]SUrl honour the state setting that comes from the…
b960d1d 
… url bar.

Fixes @ara4n's later bug in element-hq/element-web#1027
@dbkr dbkr mentioned this issue Mar 17, 2016
Merged
@dbkr dbkr closed this as completed Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
P1 T-Defect
Projects
None yet
Milestone
v0 - Friendly Beta
Development

No branches or pull requests
2 participants
@dbkr @ara4n