Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-signing: Phase I #10605

Closed
11 tasks
nadonomy opened this issue Aug 22, 2019 · 1 comment
Closed
11 tasks

Cross-signing: Phase I #10605

nadonomy opened this issue Aug 22, 2019 · 1 comment

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Aug 22, 2019

Overview

This is a parent issue to track outstanding front-end development & design issues that relate to cross-signing.

Phase I of cross-signing is being defined as an MVP for cross-signing being enabled by default, where end users can use cross-signing and establish a reasonable mental model of how encryption, trust & device verification works.

Phase II onwards will include polish and other nice to haves.

(Internal) Zeplin link, with image previews available in child issues below: https://zpl.io/2EW6lpD


Issues & outstanding

Note: I'm using this issue to track the implementation details that we arrive at within the scope of Phase I of cross-signing, as the implementation may differ to other phases or milestones that relate to e2e by default.

User profiles: #10606

  • Confirm if (+) is now redundant, instead just have [Start a DM] or [View DM] button
  • Confirm (with whoevers implementing) how much of the modality to bite off during Phase I

Inbound verification: #10607

  • Confirm we're landing Immutable DM's, if so track within Phase I of cross-signing?

Outbound verification: #10608

  • Do we need a ‘waiting for other user to accept verification’ right panel state?
  • Clarify what happens if the user is using a client that doesn’t support cross-signing
  • Confirm implications of not showing a device list until trusted
  • Confirm we’re aligned on using one device/session agnostic [Verify] button, where verification requests can be accepted by any device/session

Verify new devices at sign in: #10609

  • Approve from existing trusted devices only?

Settings: #10610

  • Confirm what to implement within the scope of cross-signing Phase I
  • Anything missing? E.g. device id’s, expose modally?

Iconography: #10611

  • Confirm how much e2e decoration to implement within the scope of cross-signing Phase I
@AmandineLP
Copy link
Contributor

Few questions, it might be better to adress your open points on a quick call ?

On User profiles: #10606

On inbound verif #10607

  • what happens when clicking on "learn more"?
    image

On Sign-in #10609

  • I think "New sign in detested" can work, but I would probably avoid talking about "sign-in" in the following messages, e.g. in "Confirm the emojis below are displyed on your new sign-in": it feels a bit clunky. I deally I guess we would say "on the new device with which you signed in" but it's long, wouldn't "on your new device" be better? Or are you worried that if they logged out from a device and are relogging in they'll be confused because it's the same physical device?
  • Do we want to propose the user to edit their device's name at the same time?

On Settings #10610

  • how can we edit our device's name?

On Iconography: #10611

  • what is an encrypted and trusted (or encrypted and trusted but with a warning) room?

@nadonomy nadonomy closed this as completed May 5, 2020
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 25, 2023
* Fixes for [CVE-2023-30609](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE-2023-30609) / GHSA-xv83-x443-7rmw
* Pick sensible default option for phone country dropdown ([\element-hq#10627](matrix-org/matrix-react-sdk#10627)). Fixes element-hq#3528.
* Relate field validation tooltip via aria-describedby ([\element-hq#10522](matrix-org/matrix-react-sdk#10522)). Fixes element-hq#24963.
* Handle more completion types in rte autocomplete ([\element-hq#10560](matrix-org/matrix-react-sdk#10560)). Contributed by @alunturner.
* Show a tile for an unloaded predecessor room if it has via_servers ([\element-hq#10483](matrix-org/matrix-react-sdk#10483)). Contributed by @andybalaam.
* Exclude message timestamps from aria live region ([\element-hq#10584](matrix-org/matrix-react-sdk#10584)). Fixes element-hq#5696.
* Make composer format bar an aria toolbar ([\element-hq#10583](matrix-org/matrix-react-sdk#10583)). Fixes element-hq#11283.
* Improve accessibility of font slider ([\element-hq#10473](matrix-org/matrix-react-sdk#10473)). Fixes element-hq#20168 and element-hq#24962.
* fix file size display from kB to KB ([\element-hq#10561](matrix-org/matrix-react-sdk#10561)). Fixes element-hq#24866. Contributed by @NSV1991.
* Handle /me in rte ([\element-hq#10558](matrix-org/matrix-react-sdk#10558)). Contributed by @alunturner.
* bind html with switch for manage extension setting option ([\element-hq#10553](matrix-org/matrix-react-sdk#10553)). Contributed by @NSV1991.
* Handle command completions in RTE ([\element-hq#10521](matrix-org/matrix-react-sdk#10521)). Contributed by @alunturner.
* Add room and user avatars to rte ([\element-hq#10497](matrix-org/matrix-react-sdk#10497)). Contributed by @alunturner.
* Support for MSC3882 revision 1 ([\element-hq#10443](matrix-org/matrix-react-sdk#10443)). Contributed by @hughns.
* Check profiles before starting a DM ([\element-hq#10472](matrix-org/matrix-react-sdk#10472)). Fixes element-hq#24830.
* Quick settings: Change the copy / labels on the options ([\element-hq#10427](matrix-org/matrix-react-sdk#10427)). Fixes element-hq#24522. Contributed by @justjanne.
* Update rte autocomplete styling ([\element-hq#10503](matrix-org/matrix-react-sdk#10503)). Contributed by @alunturner.
* Fix create subspace dialog not working ([\element-hq#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq#24882
* Fix multiple accessibility defects identified by AXE ([\element-hq#10606](matrix-org/matrix-react-sdk#10606)).
* Fix view source from edit history dialog always showing latest event ([\element-hq#10626](matrix-org/matrix-react-sdk#10626)). Fixes element-hq#21859.
* element-hq#21451 Fix WebGL disabled error message ([\element-hq#10589](matrix-org/matrix-react-sdk#10589)). Contributed by @rashmitpankhania.
* Properly translate errors in `AddThreepid.ts` so they show up translated to the user but not in our logs ([\element-hq#10432](matrix-org/matrix-react-sdk#10432)). Contributed by @MadLittleMods.
* Fix overflow on auth pages ([\element-hq#10605](matrix-org/matrix-react-sdk#10605)). Fixes element-hq#19548.
* Fix incorrect avatar background colour when using a custom theme ([\#10598](matrix-org/matrix-react-sdk#10598)). Contributed by @jdauphant.
* Remove dependency on `org.matrix.e2e_cross_signing` unstable feature ([\element-hq#10593](matrix-org/matrix-react-sdk#10593)).
* Update setting description to match reality ([\element-hq#10600](matrix-org/matrix-react-sdk#10600)). Fixes element-hq#25106.
* Fix no identity server in help & about settings ([\element-hq#10563](matrix-org/matrix-react-sdk#10563)). Fixes element-hq#25077.
* Fix: Images no longer reserve their space in the timeline correctly ([\element-hq#10571](matrix-org/matrix-react-sdk#10571)). Fixes element-hq#25082. Contributed by @kerryarchibald.
* Fix issues with inhibited accessible focus outlines ([\element-hq#10579](matrix-org/matrix-react-sdk#10579)). Fixes element-hq#19742.
* Fix read receipts falling from sky ([\element-hq#10576](matrix-org/matrix-react-sdk#10576)). Fixes element-hq#25081.
* Fix avatar text issue in rte ([\element-hq#10559](matrix-org/matrix-react-sdk#10559)). Contributed by @alunturner.
* fix resizer only work with left mouse click ([\element-hq#10546](matrix-org/matrix-react-sdk#10546)). Contributed by @NSV1991.
* Fix send two join requests when joining a room from spotlight search ([\#10534](matrix-org/matrix-react-sdk#10534)). Fixes element-hq#25054.
* Highlight event when any version triggered a highlight ([\element-hq#10502](matrix-org/matrix-react-sdk#10502)). Fixes element-hq#24923 and element-hq#24970. Contributed by @kerryarchibald.
* Fix spacing of headings of integration manager on General settings tab ([\element-hq#10232](matrix-org/matrix-react-sdk#10232)). Fixes element-hq#24085. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants